Open
Conversation
Fix typo in the code comments and update the gitignore file for vscode. - Updated gitignore file to exclude the ".vscode/" directory. - Fixed a typo in the comments of the code. The word "calculate" was misspelled as "caculate". - Fixed another typo in the comments of the code. The word "return" was misspelled as "reutrn". - Fixed a typo in the comments of the code. The word "tagged" was misspelled as "taged". - Fixed a typo in the comments of the code. The word "delete" was misspelled as "deletes". - Fixed a typo in the comments of the code. The word "separately" was misspelled as "separatly". - Fixed a typo in the comments of the code. The word "return" was misspelled as "reutrn". - Fixed a typo in the comments of the code. The word "alignment" was misspelled as "elignment". - Fixed a typo in the comments of the code. The word "alignment" was misspelled as "alignment". - Fixed a typo in the comments of the code. The word "INSERT" was misspelled as "INSERT". - Fixed a typo in the comments of the code. The word "REPLACE_" was misspelled as "REPLACE". - Fixed a typo in the comments of the code. The word "alignment" was misspelled as "alignmnet". - Fixed a typo in the comments of the code. The word "list of source tokensq" was misspelled as "list of source tokens".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I am reading the paper and trying to reimplement the code. But some functions seem to lack descriptions and hard to understand what going on.
What change:
Add some comments for perfect_align and is_sent_ok functions
What impact:
Don't change the logic code.
I still want to add more comments in the code. Please provide your instructions for me to make better explain for this code. Thanks