This repository was archived by the owner on Oct 11, 2025. It is now read-only.
Call reply closure on method event subscriptions#40
Open
joemccall86 wants to merge 2 commits intograils:5.0.xfrom
Open
Call reply closure on method event subscriptions#40joemccall86 wants to merge 2 commits intograils:5.0.xfrom
joemccall86 wants to merge 2 commits intograils:5.0.xfrom
Conversation
added 2 commits
March 23, 2022 08:24
Add unit test to spec the desired behavior when sendAndReceive is called both on a closure subscriber, and on a method subscriber
* Follow the same pattern in place for Closure subscriptions * Call the reply closure if it exists on both failure and success cases * Ensure backwards-compatibility by setting the reply closure parameter to null
|
Joe McCall seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Collaborator
|
@puneetbehl can this be merged and released' v4.0.1? I think that would also fix #43 |
Collaborator
|
Just tried to build a release version and problem in #43 is still present. I'm gonna check why that is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: We could de-duplicate this by implementing a common proceed() method in
AbstractSubscription, but I wanted to leave those re-factoring decisions up to you.Closes #39