Conversation
xnyo
added
bug
xnyo
commented
Jan 15, 2026
Comment on lines
+51
to
+57
| expAnnotations: append(slices.Clone(baseValidatorAnnotations), []act.Annotation{ | ||
| { | ||
| Level: act.AnnotationLevelWarning, | ||
| Title: "plugin-validator: Warning: Your Grafana Go SDK is older than 2 months", | ||
| Message: `Please upgrade your Grafana Go SDK to the latest version by running: "go get -u github.com/grafana/grafana-plugin-sdk-go"`, | ||
| }, | ||
| }...), |
Member
Author
There was a problem hiding this comment.
New check added in grafana/plugin-validator#486
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes validator tests for the act testing framework by addressing compatibility issues with macOS when running Docker containers and updating test expectations for the simple-backend plugin validator warnings.
Changes:
- Modified the Docker container approach from volume mounts to
docker cpto support act on macOS - Updated test expectations to include the Go SDK age warning for the simple-backend test case
- Removed redundant node_modules handling by deleting the directory instead of using empty volume mount
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/act/main_validator_test.go | Added expected annotation for Go SDK age warning in simple-backend test case using slices.Clone to avoid slice mutation |
| .github/workflows/ci.yml | Refactored Docker workflow to use docker create, docker cp, and docker start instead of docker run with volume mounts for macOS compatibility |
Comments suppressed due to low confidence (1)
.github/workflows/ci.yml:567
- The comment and
mkdir -p /tmp/emptycommand are now obsolete since the workflow no longer uses volume mounts. The empty directory was only needed for the-v "/tmp/empty:/workspace/node_modules"mount that has been removed. These lines should be deleted.
# Create an empty dir for mounting it instead of node_modules, otherwise some validator analyzers
# will recurse into the plugin's directory (including node_modules).
mkdir -p /tmp/empty
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
s4kh
approved these changes
Jan 16, 2026
github-project-automation
Bot
moved this from 🔬 In review
to 🚀 Shipped
in Grafana Catalog Team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.