Skip to content

Conversation

@xnyo
Copy link
Member

@xnyo xnyo commented Dec 18, 2025

Part of #405 and #397.

Original PR: #460, split for easier reviewing. Follow-up to #467.

Warms up act cache by caching mage, golangci-lint, trufflehog (alongside the existing go and node), speeding up tests execution

@xnyo xnyo self-assigned this Dec 18, 2025
@xnyo xnyo added the enhancement New feature or request label Dec 18, 2025
@xnyo xnyo moved this from 📬 Triage to 🔬 In review in Plugins Platform / Grafana Community Dec 18, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR optimizes the test environment setup for act (local GitHub Actions runner) by implementing better cache warmup and removing the rsync dependency. The changes read default tooling versions from ci.yml to properly warm up the cache with Go, Node.js, golangci-lint, mage, and trufflehog before running tests.

Key Changes:

  • Cache warmup now uses actual default versions from ci.yml instead of hardcoded values, and warms up additional tools (golangci-lint, mage, trufflehog)
  • Replaced rsync with native bash commands (find + xargs + cp) in the package script to eliminate external dependency
  • Added act-cache-warmup input parameter to the setup action to skip dependency detection and caching during warmup phase

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
tests/act/main_test.go Reads tooling versions from ci.yml and uses the new setup action with cache warmup mode for more comprehensive cache preparation
actions/internal/plugins/setup/action.yml Adds act-cache-warmup input and conditionally skips package manager detection and dependency caching when in warmup mode; removes rsync installation
actions/internal/plugins/package/package.sh Replaces rsync with find/xargs/cp command pipeline to copy files while excluding executables, eliminating the rsync dependency

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

xnyo and others added 4 commits December 18, 2025 18:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: 🔬 In review

Development

Successfully merging this pull request may close these issues.

1 participant