-
Notifications
You must be signed in to change notification settings - Fork 5
test(act): better cache warmup, removed rsync from package step #468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: giuseppe/caching-split-3
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR optimizes the test environment setup for act (local GitHub Actions runner) by implementing better cache warmup and removing the rsync dependency. The changes read default tooling versions from ci.yml to properly warm up the cache with Go, Node.js, golangci-lint, mage, and trufflehog before running tests.
Key Changes:
- Cache warmup now uses actual default versions from
ci.ymlinstead of hardcoded values, and warms up additional tools (golangci-lint, mage, trufflehog) - Replaced rsync with native bash commands (
find+xargs+cp) in the package script to eliminate external dependency - Added
act-cache-warmupinput parameter to the setup action to skip dependency detection and caching during warmup phase
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/act/main_test.go | Reads tooling versions from ci.yml and uses the new setup action with cache warmup mode for more comprehensive cache preparation |
| actions/internal/plugins/setup/action.yml | Adds act-cache-warmup input and conditionally skips package manager detection and dependency caching when in warmup mode; removes rsync installation |
| actions/internal/plugins/package/package.sh | Replaces rsync with find/xargs/cp command pipeline to copy files while excluding executables, eliminating the rsync dependency |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…iuseppe/caching-split-4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Part of #405 and #397.
Original PR: #460, split for easier reviewing. Follow-up to #467.
Warms up act cache by caching mage, golangci-lint, trufflehog (alongside the existing go and node), speeding up tests execution