Grafana Alertmanager: Bump alerting for templateable webhooks#11195
Merged
JacobsonMT merged 2 commits intomainfrom Apr 11, 2025
Merged
Grafana Alertmanager: Bump alerting for templateable webhooks#11195JacobsonMT merged 2 commits intomainfrom
JacobsonMT merged 2 commits intomainfrom
Conversation
rwwiv
approved these changes
Apr 11, 2025
Automatically loads the right func map that GMA uses. Actually fixes another issue in the previous code. alertingTemplates.DefaultTemplateString should be loaded *before* user defined templates so that they can be overridden.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulls in grafana/alerting#309 for templateable webhook support in remote Grafana Alertmanager.
Also changes the function remote Grafana AM uses to create the combined template to the correct one in
grafana/alerting. This makes sure it automatically loads the func map that GMA uses. This change should actually fix another issue in the previous code:alertingTemplates.DefaultTemplateStringshould be loaded before user defined templates so that they can be overridden.