Merged
Conversation
ribafish
added a commit
that referenced
this pull request
Mar 19, 2026
ribafish
force-pushed
the
gk/testcontainers-jarfiletest-workaround
branch
from
e1ca15e to
79c793d
Compare
Member
Author
|
This workaround validated here: https://github.com/gradle/develocity-oss-projects/actions/runs/23289730204 ✅ |
There was a problem hiding this comment.
Pull request overview
Adds a temporary workflow-level workaround to prevent :testcontainers:jarFileTest from causing cache-relocatability failures in experiment 3 when the upstream project is checked out in different locations.
Changes:
- Switch the workflow JDK setup from 11 to 17.
- Add a
post-checkoutgit hook that appends Gradle configuration to (a) exclude known failing volume removal tests and (b) disable caching forjarFileTestviaoutputs.doNotCacheIf(...).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
+27
to
31
| - name: Set up JDK 17 | ||
| uses: actions/setup-java@v5 | ||
| with: | ||
| java-version: 11 | ||
| java-version: 17 | ||
| distribution: "temurin" |
| // Upstream fix: https://github.com/testcontainers/testcontainers-java/pull/11574 | ||
| project(':testcontainers') { | ||
| afterEvaluate { | ||
| tasks.named('jarFileTest') { |
jprinet
approved these changes
Mar 19, 2026
|
|
||
| allprojects { | ||
| tasks.withType(Test).configureEach { | ||
| exclude '**/ComposeContainerVolumeRemovalTest*' |
Member
There was a problem hiding this comment.
Maybe a single exclude rule with **/*ContainerVolumeRemovalTest* pattern would be simpler
ribafish
changed the title
ribafish
changed the title
Bump JDK 11→17, exclude failing VolumeRemoval tests, and mark jarFileTest as non-cacheable (absolute path in systemProperty). Upstream fix: testcontainers/testcontainers-java#11574
tasks.named('jarFileTest') fails at root build.gradle evaluation time
because the task is registered in :testcontainers (core/) subproject's
own build.gradle which hasn't been evaluated yet.
ribafish
force-pushed
the
gk/testcontainers-jarfiletest-workaround
branch
from
370fa81 to
b3c3609
Compare
ribafish
changed the title
ribafish
added a commit
that referenced
this pull request
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes to the Testcontainers experiment workflow:
ContainerVolumeRemovalTest(fails in CI)doNotCacheIfworkaround forjarFileTestabsolute path cache miss in experiment 3Problem
jarFileTestsetssystemProperty("jarFile", shadowJar.outputs.files.singleFile)which embeds an absolute path as a task input. When the project is built from a different location (experiment 3), the cache key changes even though the jar content is identical.This was a temporary workaround until the upstream fix was merged:
Update
The upstream PR has been merged, so the
doNotCacheIfworkaround was removed. The post-checkout hook now only excludesContainerVolumeRemovalTest.🤖 Generated with Claude Code