Skip to content

fix: use redirect to navigate to the controller view #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spaenleh wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: use redirect to navigate to the controller view #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
465fa97
fix: use redirect to navigate to the controller view
spaenleh Dec 11, 2025
7eb5396
fix: tests
spaenleh Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions lib/admin_web/live/published_item_live/unpublish.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ defmodule AdminWeb.PublishedItemLive.Unpublish do
{:noreply,
socket
|> put_flash(:success, "Publication was removed and user notified")
|> push_navigate(to: ~p"/published_items")}
|> redirect(to: ~p"/published_items")}

{:error, changeset} ->
{:noreply, assign(socket, removal_form: to_form(changeset))}
Expand All @@ -118,6 +118,6 @@ defmodule AdminWeb.PublishedItemLive.Unpublish do
{:noreply,
socket
|> put_flash(:error, "Publication was deleted")
|> push_navigate(to: ~p"/published_items")}
|> redirect(to: ~p"/published_items")}
end
end
2 changes: 1 addition & 1 deletion test/admin_web/live/published_item_live/unpublish_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ defmodule AdminWeb.PublishedItemLive.UnpublishTest do
{:ok, lv, _html} = live(conn, ~p"/published_items/#{published_item}/unpublish")
reason = "Not appropriate"

assert {:error, {:live_redirect, _}} =
assert {:error, {:redirect, _}} =
lv
|> form("#removal_form", publication_removal_notice: %{reason: reason})
|> render_submit()
Expand Down
Loading