fix: reset readErrCount on success and lower panic threshold to 2#1022
Open
ArminEbrahimpour wants to merge 1 commit into
Open
fix: reset readErrCount on success and lower panic threshold to 2#1022ArminEbrahimpour wants to merge 1 commit into
ArminEbrahimpour wants to merge 1 commit into
Conversation
readErrCount was never reset on a successful read, meaning it could accumulate over a long-lived connection and trigger an unexpected panic. Lowered threshold from 1000 to 2, which is sufficient to support applications that check errors on every second read while still catching tight loop bugs. Panic message now includes the underlying error to aid debugging.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
readErrCount is incremented on each failed call to NextReader but is
never reset when a subsequent read succeeds. Over a long-lived
connection this can cause an unexpected panic unrelated to any current
error loop.
The threshold of 1000 also has no clear justification — large enough
to miss bugs in testing but small enough to cause surprise panics in
production after hours of normal use.
Changes
patterns while still catching tight loops