x/typesutil:modify info.Overloads to point to the overload decl#1872
Merged
xushiwei merged 2 commits intogoplus:mainfrom May 3, 2024
Merged
x/typesutil:modify info.Overloads to point to the overload decl#1872xushiwei merged 2 commits intogoplus:mainfrom
xushiwei merged 2 commits intogoplus:mainfrom
Conversation
3 tasks
eb1d988 to
e610602
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1872 +/- ##
=======================================
Coverage 93.31% 93.31%
=======================================
Files 42 42
Lines 11663 11670 +7
=======================================
+ Hits 10883 10890 +7
Misses 623 623
Partials 157 157 ☔ View full report in Codecov by Sentry. |
248c4de to
1e94a23
Compare
visualfc
reviewed
Apr 30, 2024
visualfc
reviewed
Apr 30, 2024
visualfc
reviewed
Apr 30, 2024
1e94a23 to
b0909d3
Compare
b0909d3 to
967e9bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
modify info.Overloads to point to the overload decl instead point to overload member
and modify the use of info.Overload in tools in this PR goplus/tools#270