Skip to content

x/typesutil:modify info.Overloads to point to the overload decl#1872

Merged
xushiwei merged 2 commits intogoplus:mainfrom
luoliwoshang:type-overload
May 3, 2024
Merged

x/typesutil:modify info.Overloads to point to the overload decl#1872
xushiwei merged 2 commits intogoplus:mainfrom
luoliwoshang:type-overload

Conversation

@luoliwoshang
Copy link
Copy Markdown
Member

@luoliwoshang luoliwoshang commented Apr 29, 2024

modify info.Overloads to point to the overload decl instead point to overload member

type Info struct {
        ...
	// Overloads maps identifiers to the overload decl object.
	Overloads map[*ast.Ident]types.Object
}

and modify the use of info.Overload in tools in this PR goplus/tools#270

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.31%. Comparing base (5f7a7cd) to head (b0909d3).

❗ Current head b0909d3 differs from pull request most recent head 967e9bb. Consider uploading reports for the commit 967e9bb to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1872   +/-   ##
=======================================
  Coverage   93.31%   93.31%           
=======================================
  Files          42       42           
  Lines       11663    11670    +7     
=======================================
+ Hits        10883    10890    +7     
  Misses        623      623           
  Partials      157      157           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luoliwoshang luoliwoshang force-pushed the type-overload branch 3 times, most recently from 248c4de to 1e94a23 Compare April 30, 2024 03:37
@xushiwei xushiwei requested a review from visualfc April 30, 2024 07:11
Comment thread x/typesutil/info_test.go Outdated
Comment thread x/typesutil/gopinfo.go Outdated
Comment thread x/typesutil/gopinfo.go
@xushiwei xushiwei merged commit dfd6551 into goplus:main May 3, 2024
@luoliwoshang luoliwoshang deleted the type-overload branch May 3, 2024 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants