refactor(spx): remove ixgo-aware codegen path#1500
Draft
joeykchen wants to merge 9 commits into
Draft
Conversation
There was a problem hiding this comment.
Code Review
This pull request refactors the code generation logic by removing the --ixgogen flag and transitioning from the xgobuild library to the xgo tool package. It simplifies the build process by consolidating Makefile targets, removing the internal/embeddedpkgs package, and moving embedded package registrations directly into pkg/ispx. Additionally, it introduces a more robust mechanism for resolving the xgo module environment. I have no feedback to provide.
9d0b078 to
7bd1938
Compare
7bd1938 to
9a696f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change removes the ixgo-aware codegen path from
spxand keeps embedded package handling on theispxside only.What Changed
cmd/spx/internal/gengo--ixgogenflag and related branching inspxspxcode generation to embeddedxgo/toolgo list -m github.com/goplus/xgoxgo env XGOROOT XGOVERSIONixgogenflow--goenvhelp text to reflect the current behaviorWhy
embeddedpkgsandixgo-specific handling should not leak intospx.spxshould only care about generating Go code through XGo, whileispxremains the only place that is aware of embedded package behavior.This also removes the extra codegen implementation inside
spxand keeps the generation path closer to XGo's public API.Validation
go test ./cmd/spx/... ./pkg/ispx/...