Skip to content

[Draft] Sound TTS generation doc & demo#3195

Draft
cn0809 wants to merge 3 commits into
goplus:devfrom
cn0809:tts
Draft

[Draft] Sound TTS generation doc & demo#3195
cn0809 wants to merge 3 commits into
goplus:devfrom
cn0809:tts

Conversation

@cn0809
Copy link
Copy Markdown
Collaborator

@cn0809 cn0809 commented May 21, 2026

[skip review]

update: #2768

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the first phase of AI-powered sound generation, specifically focusing on Text-to-Speech (TTS) capabilities. It includes comprehensive design documentation, updates to the OpenAPI specification, and the implementation of the frontend UI and logic, including a new SoundGen model and a SoundGenModal component. Feedback highlights an endpoint inconsistency in the documentation, missing enum values in SoundCategory for synchronization with the API, a typo in the UI text, and a suggestion to implement state persistence for the sound generation modal to match the behavior of other asset generators.

Comment thread docs/develop/sound-generation/tts-phase-1.zh.md Outdated
Comment thread spx-gui/src/apis/common/index.ts
Comment thread spx-gui/src/components/asset/gen/sound/TTSGen.vue Outdated
Comment on lines +55 to +60
export function useSoundGenModal() {
const invokeModal = useModal(SoundGenModal)
return function invokeSoundGenModal(project: SpxProject) {
return invokeModal({ project })
}
}
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Unlike useSpriteGenModal and useBackdropGenModal, the useSoundGenModal implementation does not currently support state persistence via GenState. This means any user progress in the sound generation modal will be lost if the modal is closed and reopened. Consider integrating SoundGen into GenState and GenHelpers to provide a consistent user experience across all asset generators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant