Skip to content

[Page] Update: Adjust SPX tutorial page text and color #3169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hejiaping-pipi wants to merge 1 commit into
base: ui
Choose a base branch
from
Open

[Page] Update: Adjust SPX tutorial page text and color #3169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions ui/pages/spx/tutorial.pen
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
"id": "ong2L",
"type": "ref",
"ref": "P:WiWwa",
"x": 0.0001975079347187812,
"x": 0.00018589109107464467,
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The coordinate value 0.00018589109107464467 is extremely precise and practically zero. Consider using an integer like 0 to improve readability and avoid potential floating-point precision issues in layout calculations.

          "x": 0,

Copy link
Copy Markdown
Contributor

@fennoai fennoai Bot May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Sub-pixel x-offset is floating-point noise.

Both the old value (0.0001975...) and the new value (0.00018589...) are sub-pixel and effectively zero. This is tool-generated noise that accumulates in diffs and obscures real positional changes. Consider setting this to 0.

"y": 0,
"children": [
{
Expand Down Expand Up @@ -121,14 +121,14 @@
"ref": "P:OHwu4",
"x": 0.07806559948336479,
"y": 0,
"content": "All Tutorials"
"content": "hrllo"
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The string "hrllo" appears to be a typo or a placeholder. It is recommended to use a meaningful title such as "All Tutorials" or a localized string key if supported by the format.

                      "content": "All Tutorials"

Copy link
Copy Markdown
Contributor

@fennoai fennoai Bot May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Critical: Typo in user-facing heading text.

"hrllo" is not a valid word and appears to be an accidental keystroke (likely mistyped "hello") committed while the design tool had focus. The original value "All Tutorials" is the correct section heading and matches the corresponding Vue component. This string renders directly on the tutorial page and must be corrected before merging.

},
{
"type": "frame",
"id": "ahdiv",
"name": "Course container",
"clip": true,
"width": 988,
"width": 987.9219405682865,
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The width value 987.9219405682865 is overly precise. Using non-integer values for container widths can lead to sub-pixel rendering artifacts. It is recommended to use an integer value like 988.

                      "width": 988,

Copy link
Copy Markdown
Contributor

@fennoai fennoai Bot May 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Fractional width is inconsistent with child frames.

987.9219405682865 appears to be floating-point drift from a design tool drag operation. The sibling "Course item g" frames inside this container all declare "width": 988. The container is now ~0.08px narrower than its children, which is a latent clip risk given "clip": true is set on this frame. Rounding back to 988 keeps it consistent with its children and the original intent.

"fill": "$P:grey100",
"layout": "vertical",
"gap": "$P:space-5",
Expand All @@ -154,7 +154,12 @@
{
"id": "gqB7m",
"type": "ref",
"ref": "P:XzIf9"
"ref": "P:XzIf9",
"descendants": {
"P:W0vhG5": {
"fill": "$P:blue600"
}
}
}
]
},
Expand Down