Conversation
改变(button/large/primary/shadow/square/default)背景颜色(仅测试)
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
| "id": "wH3BG", | ||
| "name": "container", | ||
| "fill": "$turquoise500", | ||
| "fill": "#e7f9faff", |
There was a problem hiding this comment.
The fill for this container was changed from the semantic design token $turquoise500 to a hardcoded hex value #e7f9faff. The rest of the file consistently uses $turquoise500 (and other $-prefixed tokens) throughout. Hardcoding the hex here means:
- This element won't update if
$turquoise500is ever changed globally. #e7f9faffis a light tint, visually distinct from$turquoise500(#0bc0cf) — this appears to be an intentional color deviation, but it should be represented as a proper design token (e.g.$turquoise100) rather than a raw hex.
Please use the design token system instead of a hardcoded color.
| "x": 0, | ||
| "y": -0.05592341929603606, | ||
| "y": -0.055923419296032506, | ||
| "descendants": { |
There was a problem hiding this comment.
These floating-point changes (e.g. -0.05592341929603606 → -0.055923419296032506) appear to be re-serialization noise from the design tool — the values are semantically identical. There are ~25 such changes throughout this diff, making it difficult to identify the one intentional change (the color on line 263).
Consider configuring the design tool to export with stable decimal precision, or adding a normalization pre-commit hook for .pen files to avoid this churn accumulating in git history.
|
The PR description explicitly marks this as "for testing only" (仅测试), but it targets the shared production component library and bumps the version to 2.10. Exploratory/test changes should live on a local or feature branch and not be merged into a shared branch. If the color change is intended to be permanent, please update the description to reflect that, use a proper design token instead of the hardcoded hex, and ensure the version bump is warranted. |
改变(button/large/primary/shadow/square/default)背景颜色(仅测试)