feat: remove attendance chat app#606
Conversation
Summary of ChangesHello @PierrickVoulet, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the repository by completely removing the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request removes the 'attendance-chat-app' sample application, as it has been moved to a different location. The changes involve deleting the entire solutions/attendance-chat-app directory. While reviewing the deleted code, I noticed a potential issue in solutions/attendance-chat-app/final/Code.gs regarding the mutation of a global constant, which could lead to race conditions. Since the code is being moved, I've left a comment on the deleted file for your consideration in the new location. Otherwise, the file removal is complete and correct.
I am having trouble creating individual review comments. Click here to see my feedback.
solutions/attendance-chat-app/final/Code.gs (72-81)
The global HEADER constant is mutated here. This is not a good practice as it introduces side effects and can lead to race conditions if the script handles multiple messages concurrently. For example, if two users interact with the app at the same time, one might see an incorrect header image. Since this code is being moved, it's a good opportunity to refactor this. A better approach would be to create a new header object within this function with the appropriate imageUrl and pass it to the createCardResponse function.
Moved to google-chat-app