-
Notifications
You must be signed in to change notification settings - Fork 108
feat: Add IAM OAuth scope to appsscript.json #297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @PierrickVoulet, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new OAuth scope to the application's configuration, enabling it to interact with Google Cloud Identity and Access Management (IAM) services. This change is crucial for functionalities that require managing permissions or accessing IAM-protected resources within the Google Cloud ecosystem. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds the https://www.googleapis.com/auth/iam OAuth scope to the application's manifest. My review identifies a critical security issue with this change. The added scope is overly permissive and not the one documented for the service account impersonation flow used in the code. I have recommended replacing it with the correct scope, https://www.googleapis.com/auth/cloud-platform, to adhere to the principle of least privilege and mitigate potential security risks.
| "chat": {} | ||
| }, | ||
| "oauthScopes": [ | ||
| "https://www.googleapis.com/auth/iam", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The https://www.googleapis.com/auth/iam scope is overly permissive and not the correct one for the intended operation. This scope grants broad permissions to manage all IAM policies, which introduces a significant security risk by violating the principle of least privilege. The Credentials.gs file shows a call to the iamcredentials.googleapis.com API to generate an access token. According to the official Google Cloud documentation, this operation requires the https://www.googleapis.com/auth/cloud-platform scope. Please use the documented scope to ensure the application only requests the permissions it strictly needs.
| "https://www.googleapis.com/auth/iam", | |
| "https://www.googleapis.com/auth/cloud-platform", |
No description provided.