Skip to content

Conversation

@PierrickVoulet
Copy link
Contributor

No description provided.

@PierrickVoulet PierrickVoulet self-assigned this Feb 3, 2026
@PierrickVoulet PierrickVoulet merged commit 4fb1e5b into main Feb 3, 2026
8 of 12 checks passed
@PierrickVoulet PierrickVoulet deleted the PierrickVoulet-patch-2 branch February 3, 2026 18:06
@gemini-code-assist
Copy link

Summary of Changes

Hello @PierrickVoulet, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new OAuth scope to the application's configuration, enabling it to interact with Google Cloud Identity and Access Management (IAM) services. This change is crucial for functionalities that require managing permissions or accessing IAM-protected resources within the Google Cloud ecosystem.

Highlights

  • OAuth Scope Addition: The https://www.googleapis.com/auth/iam OAuth scope has been added to the appsscript.json configuration file.
Changelog
  • apps-script/chat/a2ui-ai-agent/appsscript.json
    • Added the https://www.googleapis.com/auth/iam OAuth scope to the list of required permissions.
Activity
  • The pull request was created by PierrickVoulet.
  • No human activity (comments, reviews) has been recorded yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the https://www.googleapis.com/auth/iam OAuth scope to the application's manifest. My review identifies a critical security issue with this change. The added scope is overly permissive and not the one documented for the service account impersonation flow used in the code. I have recommended replacing it with the correct scope, https://www.googleapis.com/auth/cloud-platform, to adhere to the principle of least privilege and mitigate potential security risks.

"chat": {}
},
"oauthScopes": [
"https://www.googleapis.com/auth/iam",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

security-critical critical

The https://www.googleapis.com/auth/iam scope is overly permissive and not the correct one for the intended operation. This scope grants broad permissions to manage all IAM policies, which introduces a significant security risk by violating the principle of least privilege. The Credentials.gs file shows a call to the iamcredentials.googleapis.com API to generate an access token. According to the official Google Cloud documentation, this operation requires the https://www.googleapis.com/auth/cloud-platform scope. Please use the documented scope to ensure the application only requests the permissions it strictly needs.

Suggested change
"https://www.googleapis.com/auth/iam",
"https://www.googleapis.com/auth/cloud-platform",

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant