test: ensure nightly scheduled tests run all samples unconditionally#1505
Open
willum070 wants to merge 3 commits into
Open
test: ensure nightly scheduled tests run all samples unconditionally#1505willum070 wants to merge 3 commits into
willum070 wants to merge 3 commits into
Conversation
Removed FORCE_JAVASCRIPT_ACTIONS_TO_NODE24 environment variable. The 3P actions plugins in use here all depend on Node 20, so this is not needed. In general the internal runner node can use a different version of Node (even though Node 20 is slated for deprecation in September of 2026).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes the following changes:
TEST_ALL_SAMPLES: "true"is added to the test execution step's environment variables.These changes will ensure that the nightly cron job acts as a full-repo regression as originally intended.