[fea-rs] Publicize .edit(), compute ranges #1730
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmyr
approved these changes
Nov 5, 2025
Member
cmyr
left a comment
cmyr
left a comment
There was a problem hiding this comment.
Thanks, two little notes inline but otherwise happy to see this merged :)
| //! | ||
| //! This is currently unused. | ||
| #![allow(dead_code)] |
Member
There was a problem hiding this comment.
could you also remove this #![allow] please?
| /// | ||
| /// range start/end just fall on token boundaries. | ||
| pub(crate) fn edit(&self, edits: Vec<(Range<usize>, Node)>, skip_parent: bool) -> Node { | ||
| /// Assumes that the range start/end just fall on token boundaries. |
Member
There was a problem hiding this comment.
I think that 'just' was a typo for 'must', but if this is public API now I would be a bit more formal:
Suggested change
| /// Assumes that the range start/end just fall on token boundaries. | |
| /// # Panics | |
| /// | |
| /// Panics if the provided range is not the range of an existing node or token. |
Some things I noticed just now, reading through the old code:
- there's no concept of an insertion that does not replace something. (Of course you could fake this by prepending a copy of the node-to-be-replaced at the front of the replacement) This would be easy enough to add, it just wasn't needed originally.
- the edit cannot occur unless at a 'node boundary'. For instance for the statement
sub a by b;we could replace the whole statement, or we could replace any individual token, but we could not replacesub aorby b.
Contributor
Author
|
I don't need this any more as I'm rewriting the whole feature file using fea-rs-ast rather than trying to do piecemeal edits. I can clear the PR up if you still would like to see it in there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed with @cmyr yesterday - .edit() is a useful thing, but currently the ranges produced in the new tree are inaccurate and need to be recompute.