[klippa-repacker] split ligature subst table#1710
Merged
Conversation
qxliu76
force-pushed
the
split_ligature
branch
from
855c8b1 to
e935b1e
Compare
garretrieger
approved these changes
Jan 6, 2026
cmyr
approved these changes
Jan 7, 2026
Member
cmyr
left a comment
cmyr
left a comment
There was a problem hiding this comment.
Okay some notes inline but this seems reasonable.
Is there any reason for including the error change in with this PR? it seems like those should be pretty independent, and having them be separate would have made this a bit easier to review. :)
qxliu76
force-pushed
the
split_ligature
branch
2 times, most recently
from
bc8d530 to
430300d
Compare
plus change RepackerErrorFlags from bitflags to enum
qxliu76
force-pushed
the
split_ligature
branch
from
430300d to
3cab73f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
plus change RepackerErrorFlags from bitflags to enum