Conversation
cmyr
approved these changes
Jan 24, 2025
Member
cmyr
left a comment
cmyr
left a comment
There was a problem hiding this comment.
slightly confused about moving both BeBuffer into font-test-data and also moving code that uses it out of font-test-data, I assume there was some rationale there? Otherwise lgtm...
Collaborator
Author
|
BeBuffer is useful for creation of binary testdata so it is handy to have in font-test-data (and used). It's just the use of read/write types that's problemmatic so that part moves and then gets BeBuffer from font-test-data. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
font-test-data/Cargo.tomlno longer depends on read/write fonts, meaning there isn't a cycle formed by a regular dependency from font-test-data => read/write-fonts and the dev-dependency from read/write-fonts to font-test-data. Despite being theoretically OK this was confusing things during import into other enviornments.Meant to unblock #1329 , if this looks ok please mark that approved as well.