MATH table support#1269
Draft
simoncozens wants to merge 4 commits intomainfrom
Draft
Conversation
Member
|
codegen doesn't exactly expect that records are always part of arrays, but the records that aren't are special cases... I'll take a look. |
|
Is this PR under work or actually abandoned? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to implement support for the MATH table but I'm coming unstuck with the codegen.
@cmyr, is it possible that the codegen assumes that every
recordis part of an array? It's doing bad things withMathValueRecord, which seems like a simple enough structure except that it is directly embedded into various tables (MathConstantsandGlyphAssembly). These are giving errors. Where theMathValueRecordis part of an array (MathKern, for example), then all is well.