Skip to content
This repository was archived by the owner on Mar 13, 2018. It is now read-only.

[wrong CLA mail. please ignore] #73

Open
neonsoftware wants to merge 110 commits intogooglearchive:masterfrom
neonsoftware:selected-params-now-updated
Open

[wrong CLA mail. please ignore] #73
neonsoftware wants to merge 110 commits intogooglearchive:masterfrom
neonsoftware:selected-params-now-updated

Conversation

@neonsoftware
Copy link
Copy Markdown

Latest commit 0df996e was correctly adding the selected* attributes from inner more-route-selection to be updated.

Although, the fact that they are 'readOnly' was still blocking the update.
Removed. Updates are now triggered.

Potentially closes #72 and #45

nevir and others added 30 commits September 8, 2014 17:56
_compile goes back on the route prototype
favor a && b vs a ? a : b
cleanup var usage.
nevir and others added 24 commits May 5, 2015 08:58
Update to iron-flex-layout
added a missing closing <more-route> tag
Update routes.html, one missing tag
Use attrForSelected if specified
Propagate some properties from the route-selection up through the rou…
Changes readme.md references from core-pages to iron-pages, and from core-selector to iron-selector (Closes #48)
…et al) were not updated because of the 'readOnly' option. removed
@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@neonsoftware
Copy link
Copy Markdown
Author

I signed it!

@googlebot
Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@googlebot
Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@neonsoftware
Copy link
Copy Markdown
Author

Sorry, realised that git commit had wrong email, so CLA does not verify me.
Will need to re-do the commit and pull request.

@neonsoftware neonsoftware changed the title more-route-selector had selected* attributes (selectedParam, et al.) not updated to the user because of the 'readOnly' option. Removed. Getting updates now. [wrong CLA mail. please ignore] Oct 16, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

selectedParams property not set up in more-route-selector

9 participants