This repository was archived by the owner on Mar 13, 2018. It is now read-only.
Fix #52 and #53 by debouncing the firing of the 'more-route-change' event#56
Open
vguillou wants to merge 2 commits intogooglearchive:masterfrom
Open
Fix #52 and #53 by debouncing the firing of the 'more-route-change' event#56vguillou wants to merge 2 commits intogooglearchive:masterfrom
vguillou wants to merge 2 commits intogooglearchive:masterfrom
Conversation
… the 'more-route-change' event Debounce the 'more-route-change’ event to prevent a temporary selection of the base route `/` if it exists, since it is always considered as active when a more specific route is selected. See googlearchive#52 and googlearchive#53 regarding this issue.
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
Author
|
I signed it! |
|
CLAs look good, thanks! |
…173fb3ac7fc7642dd1c2d5ee
|
Please merge this, it would solve a major bug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #52 and #53 by debouncing the firing of the 'more-route-change' event.
Debounce the 'more-route-change’ event to prevent a temporary selection
of the base route
/if it exists, since it is always considered asactive when a more specific route is selected.