This repository was archived by the owner on Mar 13, 2018. It is now read-only.
Fix selected attributes get updated#54
Open
oathcomrade wants to merge 1 commit intogooglearchive:masterfrom
oathcomrade:patch-1
Open
Fix selected attributes get updated#54oathcomrade wants to merge 1 commit intogooglearchive:masterfrom oathcomrade:patch-1
oathcomrade wants to merge 1 commit intogooglearchive:masterfrom
oathcomrade:patch-1
Conversation
Because the the passed newParams object is the identical object as the oldParams just with other values (as explained here) it has to be unset first and then reset.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the the passed newParams object is the identical object as the oldParams just with other values (as explained here) it has to be unset first and then reset.