Skip to content
This repository was archived by the owner on Mar 13, 2018. It is now read-only.

Properly encode/decode parameter values#38

Open
gjdev wants to merge 2 commits intogooglearchive:masterfrom
gjdev:decodeparms
Open

Properly encode/decode parameter values#38
gjdev wants to merge 2 commits intogooglearchive:masterfrom
gjdev:decodeparms

Conversation

@gjdev
Copy link
Copy Markdown

@gjdev gjdev commented May 27, 2015

Allow for path parameters with less trivial values, containing special characters, path-part separators, etc.

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@gjdev
Copy link
Copy Markdown
Author

gjdev commented May 27, 2015

I signed it!

@googlebot
Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@gjdev
Copy link
Copy Markdown
Author

gjdev commented May 27, 2015

I did author those commits, it's just another email address.

@nevir
Copy link
Copy Markdown
Contributor

nevir commented May 27, 2015

Awesome, thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants