This repository was archived by the owner on Mar 13, 2018. It is now read-only.
Fix uncaught TypeError when this.route is null#37
Open
adalinesimonian wants to merge 2 commits intogooglearchive:masterfrom
Open
Fix uncaught TypeError when this.route is null#37adalinesimonian wants to merge 2 commits intogooglearchive:masterfrom
adalinesimonian wants to merge 2 commits intogooglearchive:masterfrom
Conversation
Merge with update to Polymer 1.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
this.routeisnull, trying to dereferencethis.route.fullPathleads to an uncaughtTypeError. This error can be easily found when trying to programmatically create an instance of<more-route>when it has no parent, as the preconditions in_identityChangedfor settingthis.routetonullare only thatthis.nameandthis.pathare both falsy, which is true when the element has just been created withdocument.createElement('more-route').Local test results after patch: