Skip to content

Conversation

@chingor13
Copy link
Contributor

Fixes #4046

@chingor13 chingor13 requested a review from blakeli0 January 8, 2026 23:42
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jan 8, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @chingor13, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates the org.json:json library into the project's shared dependency management system. This ensures that any module requiring JSON parsing or generation capabilities can leverage a consistent and centrally managed version of this library, thereby resolving a reported issue.

Highlights

  • New Dependency Added: The org.json:json library has been introduced as a managed dependency within the third-party-dependencies POM.
  • Version Management: A new property json.version has been defined to manage the version of the org.json:json library, set to 20251224.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the org.json:json dependency to the shared third-party dependencies POM. My main concern is the version specified for this new dependency, 20251224, which does not exist in Maven Central and will cause build failures. I've suggested updating it to the latest stable version. I've also included some suggestions to improve maintainability by keeping properties and dependencies sorted alphabetically in the POM file.

Copy link
Contributor

@blakeli0 blakeli0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind adding org.json:json to the dependencies.txt and use the latest version 20251224 there? We use this file to test if our client libraries are compatible with the latest dependencies.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2026

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 9, 2026

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@blakeli0 blakeli0 merged commit ffa432e into main Jan 9, 2026
62 of 65 checks passed
@blakeli0 blakeli0 deleted the add-json branch January 9, 2026 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add org.json:json to managed third-party dependencies

2 participants