Skip to content

Conversation

@surbhigarg92
Copy link
Contributor

Adding a new span attribute called gcp.resource.name which contains an identifier to a particular spanner instance and database in the following format:

//spanner.googleapis.com/projects/{project}/instances/{instance_id}/databases/{database_id}
Example:

//spanner.googleapis.com/projects/my_project/instances/my_instance/databases/my_database

@surbhigarg92 surbhigarg92 requested review from a team as code owners January 16, 2026 08:26
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jan 16, 2026
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/python-spanner API. label Jan 16, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello @surbhigarg92, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the observability of Google Cloud Spanner by adding a new OpenTelemetry span attribute, gcp.resource.name. This attribute provides a clear and consistent identifier for the specific Spanner database or instance involved in a traced operation, making it easier to understand the context and resource usage within distributed traces. The change is supported by updates to relevant tests to ensure its proper functioning.

Highlights

  • New OpenTelemetry Span Attribute: Introduced a new gcp.resource.name span attribute for OpenTelemetry tracing within Google Cloud Spanner operations.
  • Standardized Resource Identification: The new attribute provides a consistent and standardized identifier for Spanner instances and databases, formatted as //spanner.googleapis.com/projects/{project}/instances/{instance_id}/databases/{database_id}.
  • Comprehensive Test Coverage: Updated both system and unit tests across various Spanner components (tracing, sessions, batch, pooling, snapshots, transactions) to ensure the correct implementation and verification of the new gcp.resource.name attribute.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the gcp.resource.name attribute to OpenTelemetry spans, which is a valuable addition for resource identification in traces. The implementation is correct across the modified files. My main feedback is to refactor the hardcoded string "//spanner.googleapis.com/" into a constant in the _opentelemetry_tracing module and reuse it throughout the codebase. This will improve maintainability and consistency.

@surbhigarg92 surbhigarg92 force-pushed the gcp_resource_name branch 5 times, most recently from ce2d907 to 87d3a0d Compare January 16, 2026 10:26
Copy link
Contributor

@bhatt4982 bhatt4982 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@surbhigarg92 surbhigarg92 merged commit ed4735b into main Jan 16, 2026
30 of 31 checks passed
@surbhigarg92 surbhigarg92 deleted the gcp_resource_name branch January 16, 2026 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/python-spanner API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants