fix: accept grounding chunk metadata#2562
Open
he-yufeng wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2510.
Some Vertex batch responses with Google Search grounding include
groundingMetadata.groundingChunks[].chunkMetadata. The SDK currently rejects that payload becauseGroundingChunkforbids unknown fields and does not declarechunk_metadata.This adds the field to both the model and TypedDict shape so the response can validate without dropping the metadata.
Testing
I also ran
python -m pyink --check google\genai\types.py google\genai\tests\types\test_types.py; it wants to reformat the existing generated/style-preserved files wholesale, so I did not apply it.