refactor: improve variable remapping for join and in nodes #2448
+70
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
Update remap_variables to explicitly assign remapped children for JoinNode and InNode. This prevents KeyError or incorrect node reuse in self-join scenarios where identical child nodes must be remapped to unique tree branches. Additionally, explicitly remap join conditions to ensure they reference the correct child-specific column IDs. Includes a unit test verifying stability and correctness for self-joins.
chelsea-lin
force-pushed
the
main_chelsealin_perf
branch
from
c866e07 to
3bd2592
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update remap_variables to explicitly assign remapped children for JoinNode and InNode. This prevents KeyError or incorrect node reuse in self-join scenarios where identical child nodes must be remapped to unique tree branches. Additionally, explicitly remap join conditions to ensure they reference the correct child-specific column IDs.
Includes a unit test verifying stability and correctness for self-joins.