-
Notifications
You must be signed in to change notification settings - Fork 68
feat: add bigframe.bigquery.load_data function #2426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
||
| @mock.patch("bigframes.bigquery._operations.io._get_table_metadata") | ||
| def test_load_data(get_table_metadata_mock, mock_session): | ||
| bigframes.bigquery._operations.io.load_data( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest adding a doctest to each test case to better illustrate the test's purpose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean a comment for the tests or doctests to the function?
If the former case. These tests are simple and self-explanatory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doctests to the function
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The web link in the doc illustrates what the function does. https://docs.cloud.google.com/bigquery/docs/reference/standard-sql/load-statements
For this DDL, a table will be created. In doctest it can't clean that table... Which makes doctest impossible.
Generally doctests have problems, usually causing failures and hard to debug. We may want to find better ways.
PR created by the Librarian CLI to initialize a release. Merging this PR will auto trigger a release. Librarian Version: v0.7.0 Language Image: us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/python-librarian-generator@sha256:e7cc6823efb073a8a26e7cefdd869f12ec228abfbd2a44aa9a7eacc284023677 <details><summary>bigframes: 2.35.0</summary> ## [2.35.0](v2.34.0...v2.35.0) (2026-02-07) ### Features * Add bigframes.pandas.col with basic operators (#2405) ([1274167](12741677)) * remove redundant "started." messages from progress output (#2440) ([2017cc2](2017cc2f)) * add bigframe.bigquery.load_data function (#2426) ([4b0f13b](4b0f13b2)) * Disable progress bars in Anywidget mode (#2444) ([4e2689a](4e2689a1)) * add bigquery.ai.generate_text function (#2433) ([5bd0029](5bd0029a)) * Disable progress bars in Anywidget mode to reduce notebook clutter (#2437) ([853240d](853240da)) * Add a bigframes cell magic for ipython (#2395) ([e6de52d](e6de52de)) * add `bigframes.bigquery.ai.generate_embedding` (#2343) ([e91536c](e91536c8)) ### Bug Fixes * always display the results in the `%%bqsql` cell magics output (#2439) ([2d973b5](2d973b54)) * exlcude gcsfs 2026.2.0 (#2445) ([311de31](311de31e)) * suppress JSONDtypeWarning in Anywidget mode and clean up progress output (#2441) ([e0d185a](e0d185ad)) ### Documentation * fix cast method shown on public docs (#2436) ([ad0f33c](ad0f33c6)) </details>
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕