feat: add **kwargs support to XGBClassifier and XGBRegressor#2087
feat: add **kwargs support to XGBClassifier and XGBRegressor#2087
**kwargs support to XGBClassifier and XGBRegressor#2087Conversation
This is in alignment with https://xgboost.readthedocs.io/en/stable/python/python_api.html\#xgboost.XGBRegressor if considering BQML to be a booster type.
| "enable_global_explain": self.enable_global_explain, | ||
| "xgboost_version": self.xgboost_version, | ||
| } | ||
| options.update(self._extra_bqml_options) |
There was a problem hiding this comment.
It may override existing options, if user pass in both.
We use sklearn terms instead of BQML terms for existing parameters, e.g. learning_rate instead of LEARN_RATE. User may get confused looking at two sets of options at the same time.
It becomes hard for us to both stick with sklearn-like experience and support BQML other offerings.
Or maybe we can ask them to only use one set of parameters, and raise error if conflicts?
| min_rel_progress=0.01, | ||
| enable_global_explain=False, | ||
| xgboost_version='0.9', | ||
| category_encoding_method='LABEL_ENCODING', |
There was a problem hiding this comment.
Do they want to use label encoding on features? This is actually wrong. https://stackoverflow.com/a/34346937
I talked with jiashangliu@, but BQML won't change the default.
|
Closing. I think the alternative of exposing the SQL methods directly in the |
This is in alignment with https://xgboost.readthedocs.io/en/stable/python/python_api.html\#xgboost.XGBRegressor if considering BQML to be a booster type.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes internal customer request 🦕