refactor: Aggregation is now an expression subclass#2048
Merged
TrevorBergeron merged 4 commits intomainfrom Sep 4, 2025
Merged
refactor: Aggregation is now an expression subclass#2048TrevorBergeron merged 4 commits intomainfrom
TrevorBergeron merged 4 commits intomainfrom
Conversation
product-auto-label
bot
added
size: l
TrevorBergeron
force-pushed
the
agg_is_expr
branch
from
8e59987 to
75bb933
Compare
sycai
reviewed
Sep 4, 2025
| @@ -0,0 +1,151 @@ | |||
| # Copyright 2023 Google LLC | |||
Contributor
Author
There was a problem hiding this comment.
Based on my understanding of copyright, this is based partially on 2023 code, so we use 2023 even if there is new work. I think range are also possible? eg 2023-2025, but we haven't used ranges so far
Contributor
There was a problem hiding this comment.
I love how we are organizing things together.
Name suggestion for this file: "aggregations.py", because the all the classes under this file are for aggregations.
TrevorBergeron
force-pushed
the
agg_is_expr
branch
from
6cc35fd to
60a0a8d
Compare
sycai
approved these changes
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕