perf: improve iter_nodes_topo performance using Kahn's algorithm#2038
Merged
chelsea-lin merged 2 commits intomainfrom Aug 28, 2025
Merged
perf: improve iter_nodes_topo performance using Kahn's algorithm#2038chelsea-lin merged 2 commits intomainfrom
chelsea-lin merged 2 commits intomainfrom
Conversation
product-auto-label
bot
added
size: m
chelsea-lin
force-pushed
the
main_chelsealin_iternodes
branch
from
25c5bac to
524fcd3
Compare
bigframes/core/bigframe_node.py
Outdated
| [node for node in self.unique_nodes() if not node.child_nodes] | ||
| ) | ||
|
|
||
| ) -> Generator[Tuple[BigFrameNode, Sequence[BigFrameNode]], None, None]: |
Contributor
There was a problem hiding this comment.
Can we just return the node, and not the parent list? Will make this api easier to use. Can always construct the parents using the edge list if needed, no need to hyper-optimize
Contributor
Author
There was a problem hiding this comment.
makes sense. removed.
chelsea-lin
force-pushed
the
main_chelsealin_iternodes
branch
from
ed3fc4b to
94168f1
Compare
TrevorBergeron
approved these changes
Aug 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes internal issue 441746401 🦕