Conversation
| func, | ||
| by_row: typing.Union[typing.Literal["compat"], bool] = "compat", | ||
| *, | ||
| args: typing.Tuple = (), |
There was a problem hiding this comment.
In pandas args can be a positional argument while by_row is a keyword only argument https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.Series.apply.html#pandas-series-apply. I would argue that we can adhere to that right now as I don't anticipate many people passing by_row positional argument, but if not, we should add an item in BigFrames 3.0 to make the breaking change.
There was a problem hiding this comment.
Yeah, also thought about it. It’s difficult to fully match pandas API here so far. I have added some comments for potential breaking changes in the future. However, given that this is an edge case, I recommend we defer any such changes until there is a clear need based on user feedback.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes b/440342212.