feat: _read_gbq_colab creates hybrid session#1901
Merged
TrevorBergeron merged 6 commits intomainfrom Jul 24, 2025
Merged
Conversation
Collaborator
|
Let's wait for the benchmarks to run at least once before this change before merging it. |
Contributor
Author
changed to be disabled by default, but able to easily be switched by caller |
tswast
reviewed
Jul 22, 2025
bigframes/pandas/io/api.py
Outdated
| *, | ||
| pyformat_args: Optional[Dict[str, Any]] = ..., | ||
| dry_run: Literal[False] = ..., | ||
| use_hybrid_engine: bool = ..., |
Collaborator
There was a problem hiding this comment.
I suspect you'll get unit tests failing because this parameter is in bigframes.pandas but not the session.
Now that we have the benchmarks going again, I think it'd be safe to remove the parameter.
Contributor
Author
There was a problem hiding this comment.
ok ,reverted
Collaborator
|
e2e failures are unrelated. |
tswast
approved these changes
Jul 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕