fix(config): add doc/line context to parse errors#2957
Open
Deeven-Seru wants to merge 2 commits intogoogleapis:mainfrom
Open
fix(config): add doc/line context to parse errors#2957Deeven-Seru wants to merge 2 commits intogoogleapis:mainfrom
Deeven-Seru wants to merge 2 commits intogoogleapis:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request improves error reporting during configuration parsing by adding line and column details. Key changes include refactoring environment variable substitution and using YAML AST nodes for precise error locations in multi-document files. Reviewer feedback suggests optimizing the lineColumnAt function for better performance on large inputs and including the document index in YAML parsing error messages for improved consistency.
e221dc3 to
616c22c
Compare
31a7a0b to
fc432e0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add document index + line/column context to YAML config parsing errors so users can locate issues fast in multi‑doc configs. Errors now includedoc/line/col, resource name when available, and env‑var substitution points.
PR Checklist
!if this involve a breaking changeFixes #2927