tests(sdk): Fix & roll-forward "Run tests on toolbox dev version (#19)""#90
Draft
anubhav756 wants to merge 1 commit intomainfrom
Draft
tests(sdk): Fix & roll-forward "Run tests on toolbox dev version (#19)""#90anubhav756 wants to merge 1 commit intomainfrom
anubhav756 wants to merge 1 commit intomainfrom
Conversation
Contributor
|
Why are we rolling this forward? |
Contributor
Author
Not rolling forward as-is (updated the description above). I opened it so we can track the changes that were supposed to be done in the original #19, but fix it here before merging. Does that make sense? |
anubhav756
changed the title
anubhav756
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR rolls-forward #19.
We found issues in that PR here, so we reverted in #89.
We will fix the issue in this PR.