fix(toolbox-llamaindex): Align ToolboxTool properties for consistency and debuggability#293
Draft
anubhav756 wants to merge 4 commits intoanubhav-state-lcfrom
Draft
fix(toolbox-llamaindex): Align ToolboxTool properties for consistency and debuggability#293anubhav756 wants to merge 4 commits intoanubhav-state-lcfrom
ToolboxTool properties for consistency and debuggability#293anubhav756 wants to merge 4 commits intoanubhav-state-lcfrom
Conversation
anubhav756
force-pushed
the
anubhav-state-li
branch
from
d33d044 to
6d9a532
Compare
anubhav756
force-pushed
the
anubhav-state-lc
branch
from
f311bb8 to
1cef9c2
Compare
anubhav756
force-pushed
the
anubhav-state-li
branch
from
6d9a532 to
eadd7d0
Compare
Contributor
Author
|
/gcbrun |
anubhav756
force-pushed
the
anubhav-state-lc
branch
from
1cef9c2 to
11f4718
Compare
anubhav756
force-pushed
the
anubhav-state-li
branch
from
eadd7d0 to
a304b28
Compare
anubhav756
changed the title
ToolboxTool properties for consistency and debuggability
Contributor
|
Do we plan to add tests for this? |
anubhav756
force-pushed
the
anubhav-state-lc
branch
from
11f4718 to
5a98405
Compare
anubhav756
force-pushed
the
anubhav-state-li
branch
from
a304b28 to
0418ed6
Compare
anubhav756
force-pushed
the
anubhav-state-lc
branch
from
5a98405 to
40b8221
Compare
anubhav756
force-pushed
the
anubhav-state-li
branch
from
0418ed6 to
0a69d9f
Compare
Contributor
Author
Added. Thanks for pointing that out. |
anubhav756
force-pushed
the
anubhav-state-lc
branch
from
937b1fc to
1d2a960
Compare
anubhav756
force-pushed
the
anubhav-state-li
branch
from
26cd877 to
44a5813
Compare
anubhav756
force-pushed
the
anubhav-state-lc
branch
2 times, most recently
from
6fa70b7 to
34497fd
Compare
anubhav756
force-pushed
the
anubhav-state-li
branch
from
44a5813 to
35660b2
Compare
anubhav756
force-pushed
the
anubhav-state-lc
branch
from
34497fd to
20b7968
Compare
anubhav756
force-pushed
the
anubhav-state-li
branch
from
35660b2 to
c7c7c7b
Compare
anubhav756
force-pushed
the
anubhav-state-lc
branch
from
20b7968 to
501be35
Compare
anubhav756
force-pushed
the
anubhav-state-li
branch
from
c7c7c7b to
b81d7b7
Compare
anubhav756
force-pushed
the
anubhav-state-lc
branch
from
501be35 to
3ecad9d
Compare
anubhav756
force-pushed
the
anubhav-state-li
branch
from
b81d7b7 to
35f5cf7
Compare
anubhav756
force-pushed
the
anubhav-state-li
branch
from
35f5cf7 to
dac36c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors the
ToolboxToolintoolbox-llamaindexto align its public API with thetoolbox-langchainpackage (#294).This provides a consistent developer experience across both ecosystems and also improves debuggability by making the tool's internal state transparent and inspectable.
Changes
The following read-only properties are now publicly exposed on the
ToolboxTool, mirroring the core/langchain interface:_bound_params_required_authn_params_required_authz_tokens_auth_service_token_getters_client_headers