feat(librarian): default settings for Swift packages#5280
Merged
coryan merged 2 commits intogoogleapis:mainfrom Apr 14, 2026
Merged
feat(librarian): default settings for Swift packages#5280coryan merged 2 commits intogoogleapis:mainfrom
coryan merged 2 commits intogoogleapis:mainfrom
Conversation
Most of the Swift packages will use a common configuration in `librarian.yaml`, this PR introduces that common configuration and uses it to populate each library's config.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces Swift-specific configuration support, including default dependency filling, merging logic, and sorting during configuration tidying. A logic error was identified in the fillDefaults function where early returns prevent the application of defaults for multiple languages. It is recommended to refactor this function to process all language-specific defaults sequentially and to sort these checks alphabetically for consistency.
chingor13
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of the Swift packages will use a common configuration in
librarian.yaml, this PR introduces that common configuration and uses it to populate each library's config.Towards #5179