Skip to content

Conversation

@surbhigarg92
Copy link
Contributor

Adding a new span attribute called gcp.resource.name which contains an identifier to a particular spanner instance and database in the following format:

//spanner.googleapis.com/projects/{project}/instances/{instance_id}/databases/{database_id}
Example:

//spanner.googleapis.com/projects/my_project/instances/my_instance/databases/my_database

@surbhigarg92 surbhigarg92 requested review from a team as code owners January 16, 2026 08:33
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/java-spanner API. labels Jan 16, 2026
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @surbhigarg92, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances observability for Google Cloud Spanner by introducing a new "gcp.resource.name" attribute to OpenTelemetry spans. This attribute provides a standardized, fully qualified resource identifier for Spanner instances and databases, making it easier to trace and monitor specific resources within distributed systems.

Highlights

  • New Span Attribute: Introduces a new OpenTelemetry span attribute, "gcp.resource.name", to provide a unique identifier for Google Cloud Spanner instances and databases.
  • Resource Name Format: The "gcp.resource.name" attribute is formatted as a full resource path, e.g., "//spanner.googleapis.com/projects/{project}/instances/{instance_id}/databases/{database_id}".
  • Test Coverage: Adds a new test assertion to "OpenTelemetrySpanTest" to ensure the "gcp.resource.name" attribute is correctly set and verified in generated spans.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new span attribute gcp.resource.name to traces, which is a great addition for resource identification in GCP. The implementation looks correct and follows the format specified in the description. I've added a couple of suggestions to improve code maintainability by reducing magic strings in both the implementation and the test.

surbhigarg92 and others added 2 commits January 16, 2026 14:14
…enTelemetrySpanTest.java

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@rahul2393 rahul2393 merged commit f689783 into main Jan 16, 2026
59 of 61 checks passed
@rahul2393 rahul2393 deleted the gcp_resource_name branch January 16, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants