-
Notifications
You must be signed in to change notification settings - Fork 136
chore: Add gcp resource name span attribute #4306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @surbhigarg92, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances observability for Google Cloud Spanner by introducing a new "gcp.resource.name" attribute to OpenTelemetry spans. This attribute provides a standardized, fully qualified resource identifier for Spanner instances and databases, making it easier to trace and monitor specific resources within distributed systems. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds a new span attribute gcp.resource.name to traces, which is a great addition for resource identification in GCP. The implementation looks correct and follows the format specified in the description. I've added a couple of suggestions to improve code maintainability by reducing magic strings in both the implementation and the test.
google-cloud-spanner/src/main/java/com/google/cloud/spanner/TraceWrapper.java
Outdated
Show resolved
Hide resolved
google-cloud-spanner/src/test/java/com/google/cloud/spanner/OpenTelemetrySpanTest.java
Outdated
Show resolved
Hide resolved
fd7726b to
98275f5
Compare
…enTelemetrySpanTest.java Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
d28bc69 to
1380eb7
Compare
Adding a new span attribute called gcp.resource.name which contains an identifier to a particular spanner instance and database in the following format:
//spanner.googleapis.com/projects/{project}/instances/{instance_id}/databases/{database_id}
Example:
//spanner.googleapis.com/projects/my_project/instances/my_instance/databases/my_database