-
Notifications
You must be signed in to change notification settings - Fork 136
docs: Add snippet for ReadLockMode configuration at client and transaction #4305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Here is the summary of changes. You are about to add 2 region tags.
You are about to delete 1 region tag.
This comment is generated by snippet-bot.
|
Summary of ChangesHello @shobhitsg, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the documentation and examples for Google Cloud Spanner by providing a dedicated sample that illustrates how to configure transaction isolation levels and read lock modes. This change clarifies the application of these settings at both the client and individual transaction levels, emphasizing the precedence of transaction-specific configurations. The refactoring improves the discoverability and clarity of these advanced transaction options within the sample codebase. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces new code snippets to demonstrate the configuration of IsolationLevel and ReadLockMode for Spanner transactions, both at the client and transaction level. The existing isolationLevelSetting snippet has been moved from SpannerSample.java to a new, dedicated file IsolationLevelAndReadLockModeSample.java, which now also includes the new readLockModeSetting snippet.
My review focuses on the new file. I've identified a resource leak where ResultSet is not being closed, and I've provided suggestions to fix this using try-with-resources. I also noted significant code duplication between the two new snippet methods and recommend refactoring to improve maintainability.
samples/snippets/src/main/java/com/example/spanner/IsolationLevelAndReadLockModeSample.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/spanner/IsolationLevelAndReadLockModeSample.java
Outdated
Show resolved
Hide resolved
samples/snippets/src/main/java/com/example/spanner/IsolationLevelAndReadLockModeSample.java
Show resolved
Hide resolved
a1c50b5 to
92805d7
Compare
|
@shobhitsg You need to write an integration tests for this. |
New Sample: Added IsolationLevelAndReadLockModeSample.java to demonstrate Cloud Spanner transaction configurations.
Refactoring: Moved the isolation level example from SpannerSample.java to the new file for better organization.
Dependency Update: Bumped libraries-bom in pom.xml from 26.71.0 to 26.73.0.