Skip to content

Conversation

@shobhitsg
Copy link
Contributor

@shobhitsg shobhitsg commented Jan 16, 2026

New Sample: Added IsolationLevelAndReadLockModeSample.java to demonstrate Cloud Spanner transaction configurations.

Refactoring: Moved the isolation level example from SpannerSample.java to the new file for better organization.

Dependency Update: Bumped libraries-bom in pom.xml from 26.71.0 to 26.73.0.

@shobhitsg shobhitsg requested review from a team as code owners January 16, 2026 05:51
@snippet-bot
Copy link

snippet-bot bot commented Jan 16, 2026

Here is the summary of changes.

You are about to add 2 region tags.
You are about to delete 1 region tag.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: spanner Issues related to the googleapis/java-spanner API. labels Jan 16, 2026
@gemini-code-assist
Copy link

Summary of Changes

Hello @shobhitsg, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the documentation and examples for Google Cloud Spanner by providing a dedicated sample that illustrates how to configure transaction isolation levels and read lock modes. This change clarifies the application of these settings at both the client and individual transaction levels, emphasizing the precedence of transaction-specific configurations. The refactoring improves the discoverability and clarity of these advanced transaction options within the sample codebase.

Highlights

  • New Sample Added: Introduced a new dedicated sample file, IsolationLevelAndReadLockModeSample.java, to demonstrate the configuration of IsolationLevel and ReadLockMode for Google Cloud Spanner transactions.
  • Code Refactoring: The isolationLevelSetting example has been moved from the general SpannerSample.java file into the new, more focused sample, improving code organization.
  • Dependency Update: Updated the libraries-bom dependency version in pom.xml from 26.71.0 to 26.73.0.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces new code snippets to demonstrate the configuration of IsolationLevel and ReadLockMode for Spanner transactions, both at the client and transaction level. The existing isolationLevelSetting snippet has been moved from SpannerSample.java to a new, dedicated file IsolationLevelAndReadLockModeSample.java, which now also includes the new readLockModeSetting snippet.

My review focuses on the new file. I've identified a resource leak where ResultSet is not being closed, and I've provided suggestions to fix this using try-with-resources. I also noted significant code duplication between the two new snippet methods and recommend refactoring to improve maintainability.

@shobhitsg shobhitsg force-pushed the read_lock_mode_sample branch from a1c50b5 to 92805d7 Compare January 16, 2026 05:55
@sakthivelmanii
Copy link
Collaborator

@shobhitsg You need to write an integration tests for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants