docs: Generate samples for simple RPCs#4095
Closed
amanda-tarafa wants to merge 3 commits intogoogleapis:mainfrom
Closed
docs: Generate samples for simple RPCs#4095amanda-tarafa wants to merge 3 commits intogoogleapis:mainfrom
amanda-tarafa wants to merge 3 commits intogoogleapis:mainfrom
Conversation
product-auto-label
Bot
added
the
samples
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4095 +/- ##
==========================================
+ Coverage 94.78% 94.80% +0.01%
==========================================
Files 182 182
Lines 6885 6885
==========================================
+ Hits 6526 6527 +1
+ Misses 359 358 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
amanda-tarafa
force-pushed
the
get-rpc-samples
branch
from
0e10838 to
4d0ebcd
Compare
amanda-tarafa
force-pushed
the
get-rpc-samples
branch
3 times, most recently
from
17e35f5 to
8b7aa34
Compare
Contributor
Author
|
Test failures are unrelated to this PR, and seem to be in some Storage tests, for example: 
|
amanda-tarafa
force-pushed
the
get-rpc-samples
branch
2 times, most recently
from
dce3a06 to
09a96e7
Compare
amanda-tarafa
force-pushed
the
get-rpc-samples
branch
from
09a96e7 to
d719501
Compare
dbolduc
reviewed
Dec 23, 2025
| /// # use google_cloud_secretmanager_v1::client::SecretManagerService; | ||
| /// async fn sample( | ||
| /// client: &SecretManagerService | ||
| /// ) -> gax::Result<()> { |
Member
There was a problem hiding this comment.
nit: I think we would prefer to use the re-exported Result over gax::Result:
# use google_cloud_secretmanager_v1::Result;
async fn sample(...) -> Result<()> { ... }
amanda-tarafa
force-pushed
the
get-rpc-samples
branch
from
d719501 to
0f965e3
Compare
Contributor
Author
|
Closing, and sending anew, instead of rebasing on top of recent changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.