Skip to content

feat(google-devicesandservices-health): add google-devicesandservices-health#17365

Merged
parthea merged 1 commit into
googleapis:mainfrom
suztomo:onboard_health
Jun 3, 2026
Merged

feat(google-devicesandservices-health): add google-devicesandservices-health#17365
parthea merged 1 commit into
googleapis:mainfrom
suztomo:onboard_health

Conversation

@suztomo
Copy link
Copy Markdown
Member

@suztomo suztomo commented Jun 3, 2026 •
edited
Loading

I manually added the namespaces in librarian.yaml;

  python:
    allowed_namespaces:
      - google.ads
      - google.apps
      - google.cloud
      - google.maps
      - google.shopping
      - google.devicesandservices

I ran:

~/librarian-2026/google-cloud-python$ go run github.com/googleapis/librarian/cmd/librarian@${V} add google/devicesandservices/health/v4
~/librarian-2026/google-cloud-python$ docker run -u $(id -u):$(id -g) -v .:/repo -v ~/.cache:/.cache -w /repo   docker.io/library/librarian-python:${V}  generate -v google-devicesandservices-health

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jun 3, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the new google-devicesandservices-health client library (version 0.0.0) for Python, which provides clients, transports, pagers, and types to interact with the Google Health API (specifically DataPointsService and DataSubscriptionService). The changes include adding the library to the librarian configuration files, setting up package metadata, documentation, and generating the complete Python client codebase. One issue was identified in the generated __init__.py file where a warning string literal is missing an f prefix, preventing proper interpolation of the {_package_label} variable.

Comment thread packages/google-devicesandservices-health/google/devicesandservices/health_v4/__init__.py
warnings.warn(
"Could not determine the version of Python "
+ "currently being used. To continue receiving "
+ "updates for {_package_label}, ensure you are "
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Jun 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The string literal contains {_package_label} but is missing the f prefix, meaning the variable will not be interpolated and will be printed literally. Please add the f prefix to enable string interpolation.

Suggested change
+ "updates for {_package_label}, ensure you are "
+ f"updates for {_package_label}, ensure you are "

@suztomo suztomo marked this pull request as ready for review June 3, 2026 19:12
@suztomo suztomo requested review from a team as code owners June 3, 2026 19:12
@snippet-bot
Copy link
Copy Markdown

snippet-bot Bot commented Jun 3, 2026

Here is the summary of changes.

You are about to add 50 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@parthea parthea merged commit f9ff3b1 into googleapis:main Jun 3, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@parthea parthea parthea approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@suztomo @parthea