feat: migrate gemini default and deprecations to gemini-2.5-pro#17355
Open
shuoweil wants to merge 1 commit into
Open
feat: migrate gemini default and deprecations to gemini-2.5-pro#17355shuoweil wants to merge 1 commit into
shuoweil wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the default LLM model from 'gemini-2.0-flash-001' to 'gemini-2.5-pro' and expands the deprecation warning logic to cover older Gemini models, recommending 'gemini-2.5-pro' as the replacement. Corresponding unit and system tests, along with SQL compilation snapshots, have been updated to use the new model. Feedback suggests simplifying the multiple 'startswith' checks in the deprecation logic by passing a tuple of prefixes to a single 'startswith' call.
Comment on lines
+525
to
+529
| if ( | ||
| self.model_name.startswith("gemini-2.0") | ||
| or self.model_name.startswith("gemini-1.5") | ||
| or self.model_name in ("gemini-2.5-flash", "gemini-2.5-flash-lite", "gemini-2.5-pro-preview-05-06") | ||
| ): |
Contributor
There was a problem hiding this comment.
The multiple startswith checks can be simplified and made more readable by passing a tuple of prefixes to startswith.
if (
self.model_name.startswith(("gemini-2.0", "gemini-1.5"))
or self.model_name in ("gemini-2.5-flash", "gemini-2.5-flash-lite", "gemini-2.5-pro-preview-05-06")
):
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the default Gemini model and deprecation warnings in bigframes to align with model policy updates taking effect on June 15, 2026.
Fixes #<519302924> 🦕