fix(bigtable): ensure deadline is respected for read_rows_sharded#17352
Open
daniel-sanche wants to merge 1 commit into
Open
fix(bigtable): ensure deadline is respected for read_rows_sharded#17352daniel-sanche wants to merge 1 commit into
daniel-sanche wants to merge 1 commit into
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a lock (gen_lock) to ensure that rpc_timeout_generator is thread-safe during sharded row reads in both the async and sync clients. Additionally, it updates the unit tests to use CrossSync.sleep and CrossSync._Sync_Impl.sleep instead of asyncio.sleep, and increases the test operation timeout. A review comment correctly identifies a missing import of CrossSync in the async unit tests, which would lead to a NameError during execution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The read_rows_sharded tests were flaky. It seems this mostly came down to not having a mutex on the timeout generator, which isn't completely thread safe in the sync context. This ensures that the timeout is always accessed sequentially
Also increase the timeout in the test, to prevent future flakes