chore: remove prerelease and unit tests for goldens#17331
Draft
ohmayr wants to merge 1 commit into
Draft
Conversation
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We are defining a purpose for each of our testing type. Goldens should verify that the generated code is syntactically valid Python code.
These tests are run downstream so having them here is redundant. In the long run, they will be removed from downstream as well and will be run for showcase and a list of canaries upstream only.
Changes introduced:
Deleted the goldens-prerelease job: Removed
prerelease_depsandcore_deps_from_sourcefrom the PR blocking path.Stripped unit execution from the goldens job: Removed the
unit-${{ ... }}Nox session. The goldens job now strictly runs static structural checks (format, lint, and pylint).