Skip to content

test(ndb): fix project ID leak in tests#16753

Merged
chalmerlowe merged 1 commit into
mainfrom
fix-ndb-test-project-leak
Apr 21, 2026
Merged

test(ndb): fix project ID leak in tests#16753
chalmerlowe merged 1 commit into
mainfrom
fix-ndb-test-project-leak

Conversation

@chalmerlowe
Copy link
Copy Markdown
Contributor

This PR fixes a project ID leak in NDB tests where environment variables were not cleared, causing failures when run against core dependencies at HEAD.

@chalmerlowe chalmerlowe requested a review from a team as a code owner April 21, 2026 18:17
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates unit tests in test_client.py to use mock.patch.dict with clear=True for environment variable manipulation, ensuring tests run in a controlled environment. I have no feedback to provide.

@chalmerlowe chalmerlowe merged commit 45517d6 into main Apr 21, 2026
30 checks passed
@chalmerlowe chalmerlowe deleted the fix-ndb-test-project-leak branch April 21, 2026 19:09
@chalmerlowe chalmerlowe added this to the Update nox sessions milestone May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants