fix(spanner): clear metrics tracers after operation completion#8172
Open
fix(spanner): clear metrics tracers after operation completion#8172
Conversation
Allow MetricsTracerFactory.clearCurrentTracer to accept the already-extracted operation request id stored on MetricsTracer. This ensures completed operations remove their tracer entries instead of retaining them until the periodic cleanup threshold.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the clearCurrentTracer method in MetricsTracerFactory to use the requestId as a fallback if the operation request extraction fails. It also includes a new test case to ensure that tracers and their associated metadata are correctly removed from internal maps when clearing. I have no feedback to provide as there were no review comments to evaluate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MetricsTracerFactory.clearCurrentTracer()to handle already-extracted operation request IDs_currentOperationTracersuntil periodic cleanupWhy
createMetricsTracer()stores tracers by extracted operation request ID. Later,MetricsTracer.recordOperationCompletion()callsclearCurrentTracer()with that already-extracted ID.clearCurrentTracer()attempted to extract again, failed to match the regex, and used an empty key. The stored tracerwas not removed, so
_currentOperationTracersand_currentOperationLastUpdatedMsgrew with every operation until the 60-minute cleanup threshold.