chore: consolidate eslint rules#8155
Open
shivanee-p wants to merge 6 commits intomainfrom
Open
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds Prettier as a runtime dependency to the GAPIC generator for TypeScript and updates numerous baseline files to reflect the new formatting standards. The changes primarily involve consistent spacing in imports and exports, multi-line formatting for long parameter lists, and the addition of trailing commas. I have no feedback to provide.
shivanee-p
force-pushed
the
shivaneep-consolidate-eslint-rules
branch
3 times, most recently
from
31498f4 to
bd02443
Compare
shivanee-p
force-pushed
the
shivaneep-consolidate-eslint-rules
branch
from
63ba276 to
8a2b207
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is another step to implement a CI ESLint check. This PR centralizes the generated libraries' directories ESLint configurations, replacing local, duplicative configurations (.eslintrc.json and .eslintignore) with unified workspace directives inside the packages/ root directory.
Key Changes:
Note: the handwritten libraries is out of scope for this PR. They will be handled in a subsequent PR.