fix: Remove system tests from generated packages#8146
Draft
danieljbruce wants to merge 2 commits intomainfrom
Draft
fix: Remove system tests from generated packages#8146danieljbruce wants to merge 2 commits intomainfrom
danieljbruce wants to merge 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the pack-n-play dependency and associated system tests across numerous Google Cloud client library packages, generally replacing the system-test script with a placeholder. The review identifies that the system-test script was not updated in the package.json files for google-cloud-automl, google-cloud-billing-budgets, and google-cloud-compute, which will likely cause execution failures. These scripts should be updated to "echo no system tests" for consistency and to prevent build errors.
| "long": "^5.3.1", | ||
| "mocha": "^11.1.0", | ||
| "null-loader": "^4.0.1", | ||
| "pack-n-play": "^3.0.0", |
Contributor
There was a problem hiding this comment.
| "linkinator": "^6.1.2", | ||
| "long": "^5.3.1", | ||
| "mocha": "^11.1.0", | ||
| "pack-n-play": "^3.0.0", |
Contributor
There was a problem hiding this comment.
| "linkinator": "^6.1.2", | ||
| "long": "^5.3.1", | ||
| "mocha": "^11.1.0", | ||
| "pack-n-play": "^3.0.0", |
Contributor
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Solves issue #8021 by doing the following:
Impact