Skip to content

fix: Remove system tests from generated packages#8146

Draft
danieljbruce wants to merge 2 commits intomainfrom
remove-tests-from-generated-packages
Draft

fix: Remove system tests from generated packages#8146
danieljbruce wants to merge 2 commits intomainfrom
remove-tests-from-generated-packages

Conversation

@danieljbruce
Copy link
Copy Markdown
Contributor

Description

Solves issue #8021 by doing the following:

  • Removes system tests that are not needed anymore
  • Modifies package.json files so that they do not try to run the deleted system tests

Impact

  • Improves CI runtime
  • Removes generated tests which are guaranteed to pass and therefore don't provide any value.

@danieljbruce danieljbruce changed the title Remove tests from generated packages fix: Remove system tests from generated packages May 1, 2026
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the pack-n-play dependency and associated system tests across numerous Google Cloud client library packages, generally replacing the system-test script with a placeholder. The review identifies that the system-test script was not updated in the package.json files for google-cloud-automl, google-cloud-billing-budgets, and google-cloud-compute, which will likely cause execution failures. These scripts should be updated to "echo no system tests" for consistency and to prevent build errors.

"long": "^5.3.1",
"mocha": "^11.1.0",
"null-loader": "^4.0.1",
"pack-n-play": "^3.0.0",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The pack-n-play dependency and its corresponding system tests have been removed, but the system-test script was not updated. This will likely cause npm run system-test to fail. Please update the script to "echo no system tests" for consistency with other packages in this PR.

"linkinator": "^6.1.2",
"long": "^5.3.1",
"mocha": "^11.1.0",
"pack-n-play": "^3.0.0",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The pack-n-play dependency and its corresponding system tests have been removed, but the system-test script was not updated. This will likely cause npm run system-test to fail. Please update the script to "echo no system tests" for consistency with other packages in this PR.

"linkinator": "^6.1.2",
"long": "^5.3.1",
"mocha": "^11.1.0",
"pack-n-play": "^3.0.0",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The pack-n-play dependency and its corresponding system tests have been removed, but the system-test script was not updated. This will likely cause npm run system-test to fail. Please update the script to "echo no system tests" for consistency with other packages in this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant